Add upgrade test for new defaults #6165
Conversation
This adds a new test using BYO Revision name to make sure that the immutability contract is not violated by adding new defaults to the Service template. Fixes knative#6077
knative-prow-robot
added
size/M
There was a problem hiding this comment.
@dgerd: 0 warnings.
In response to this:
This adds a new test using BYO Revision name to make sure that the
immutability contract is not violated by adding new defaults to the
Service template.Fixes #6077
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
approved
|
/assign @vagababov |
| func TestBYORevisionPostUpgrade(t *testing.T) { | ||
| t.Parallel() | ||
| clients := e2e.Setup(t) | ||
| var names test.ResourceNames |
There was a problem hiding this comment.
names := test.RN {
Service: x,
}
As done below.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds a new test using BYO Revision name to make sure that the
immutability contract is not violated by adding new defaults to the
Service template.
Fixes #6077