-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds dev container and updates docs with Codespaces information #13838
Adds dev container and updates docs with Codespaces information #13838
Conversation
Signed-off-by: Samruddhi Khandale <samruddhikhandale@github.com>
|
Welcome @samruddhikhandale! It looks like this is your first PR to knative/serving 🎉 |
Hi @samruddhikhandale. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #13838 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 198 198
Lines 14669 14669
=======================================
Hits 12659 12659
+ Misses 1713 1712 -1
- Partials 297 298 +1 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Looks good - just one last minor thing |
great thanks for the help! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, samruddhikhandale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reference: #13806
You can test these changes with Codespaces by simply clicking on the
Code
icon on top right side of this PR ☝️Release Note