Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dev container and updates docs with Codespaces information #13838

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Adds dev container and updates docs with Codespaces information #13838

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3be4321
Adds dev container and updates docs with Codespaces information
samruddhikhandale Mar 31, 2023
59ac270
address comments
samruddhikhandale Mar 31, 2023
04d7770
address comments
samruddhikhandale Apr 3, 2023
ac6ed11
remove go Feature; source instead
samruddhikhandale Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// For format details, see https://aka.ms/devcontainer.json.
samruddhikhandale marked this conversation as resolved.
Show resolved Hide resolved
{
"name": "Knative Serving",
"image": "gcr.io/knative-tests/test-infra/prow-tests:latest",

// Features to add to the dev container. More info: https://containers.dev/features.
"features": {
"ghcr.io/devcontainers/features/go:1": {}
samruddhikhandale marked this conversation as resolved.
Show resolved Hide resolved
},

"privileged": true,
"postStartCommand": "service docker start",
"mounts": [
{
"source": "dind-var-lib-docker",
"target": "/docker-graph",
"type": "volume"
}
]
}
10 changes: 10 additions & 0 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@ meet these requirements, you can make changes and

Before submitting a PR, see also [CONTRIBUTING.md](./CONTRIBUTING.md).

## Getting started with GitHub Codespaces

To get started, create a codespace for this repository by clicking this 👇

[![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://github.com/codespaces/new?hide_repo_select=true&ref=main&repo=118828329)

A codespace will open in a web-based version of Visual Studio Code. The [dev container](.devcontainer/devcontainer.json) is fully configured with software needed for this project.

**Note**: Dev containers is an open spec which is supported by [GitHub Codespaces](https://github.com/codespaces) and [other tools](https://containers.dev/supporting).

samruddhikhandale marked this conversation as resolved.
Show resolved Hide resolved
### Sign up for GitHub

Start by creating [a GitHub account](https://github.com/join), then set up
Expand Down