Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defmt-print: Log if malformed frame gets skipped #610

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Conversation

Urhengulas
Copy link
Member

@Urhengulas Urhengulas commented Oct 11, 2021

Also add --verbose-flag to also show non-defmt logs.

Fixes #609

Example

❯ bat defmt-frames | cargo run -- -e hello -v
    Finished dev [unoptimized + debuginfo] target(s) in 0.02s
     Running `/home/urhengulas/Documents/github.com/knurling-rs/defmt/target/debug/defmt-print -e hello -v`
0 INFO  Lorem Ipsum is simply dummy text
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:8
1 INFO  of the printing and typesetting 
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:9
2 INFO  industry. Lorem Ipsum has been the 
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:10
(HOST) WARN  malformed frame skipped
└─ defmt_print @ print/src/main.rs:79
4 INFO  since the 1500s, when an unknown printer 
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:12
5 INFO  took a galley of type and scrambled it to 
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:13
6 INFO  make a type specimen book.

Copy link
Contributor

@justahero justahero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Urhengulas
Copy link
Member Author

bors r=justahero

@bors
Copy link
Contributor

bors bot commented Oct 21, 2021

Build succeeded:

@bors bors bot merged commit 033fbcb into main Oct 21, 2021
@bors bors bot deleted the refactor-defmt-print branch October 21, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate a faulty frame is skipped
2 participants