This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Enable deactivated tests for Windows #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate the test to check behaviour on Windows. This also uses the [dirs](https://github.com/dirs-dev/dirs-rs) crate to get the user's home directory, e.g. `C:\Users\<user>\`. It also looks like the
This refactors the code to use `PathBuf::join` to create paths from.
justahero
force-pushed
the
fix-windows-tests
branch
from
d437fa0
to
e09377d
Compare
* prepend home directory to have an absolute path on Unix & Windows
justahero
changed the title
Urhengulas
reviewed
Aug 16, 2021
* deref `path` instead of calling `.as_path()`
* use `PathBuf::from` instead of `PathBuf::new`
|
bors r+ |
Urhengulas
approved these changes
Aug 19, 2021
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables a number of tests to run on Windows, which were previously only tested on Unix-like systems.
PathBuf::joinFixes #227