Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Enable deactivated tests for Windows #246

Merged
merged 13 commits into from
Aug 19, 2021
Merged

Enable deactivated tests for Windows #246

merged 13 commits into from
Aug 19, 2021

Commits on Aug 16, 2021

  1. Add dirs crate to get OS specific folders

    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    a2f9f21 View commit details
    Browse the repository at this point in the history

  2. Split test to be OS specific 

    Duplicate the test to check behaviour on Windows. This also uses the
[dirs](https://github.com/dirs-dev/dirs-rs) crate to get the user's
home directory, e.g. `C:\Users\<user>\`.

It also looks like the
    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    1d4a993 View commit details
    Browse the repository at this point in the history

  3. Use system path separator 

    This refactors the code to use `PathBuf::join` to create paths from.
    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    6bd998c View commit details
    Browse the repository at this point in the history

  4. Merged both tests to run on Unix / Windows

    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    bd184ad View commit details
    Browse the repository at this point in the history

  5. Refactor test to pass on Windows

    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    cbec724 View commit details
    Browse the repository at this point in the history

  6. Refactor test to run on Unix / Windows

    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    70fc89e View commit details
    Browse the repository at this point in the history

  7. Refactor test to use PathBuf

    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    e09377d View commit details
    Browse the repository at this point in the history

  8. Refactor test to use PathBuf 

    * prepend home directory to have an absolute path on Unix & Windows
    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    1ba1986 View commit details
    Browse the repository at this point in the history

  9. Refactor general test to run on Windows

    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    234af0c View commit details
    Browse the repository at this point in the history

  10. Fix lint warnings

    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    9daef89 View commit details
    Browse the repository at this point in the history

  11. Integrate review feedback 

    * deref `path` instead of calling `.as_path()`
    @justahero
    justahero committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    64b0600 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Minor refactoring 

    * use `PathBuf::from` instead of `PathBuf::new`
    @justahero
    justahero committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    6c3af5b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. More minor refactor

    @Urhengulas
    Urhengulas committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    a2591a6 View commit details
    Browse the repository at this point in the history