Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsSupportedReference returns descriptive error #233

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

imjasonh
Copy link
Member

This can be useful to determine what they need to do to make a ko
publish work.

This can be useful to determine what they need to do to make a ko
publish work.
@imjasonh imjasonh requested a review from mattmoor October 31, 2020 15:33
@codecov-io
Copy link

Codecov Report

Merging #233 into master will increase coverage by 0.13%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   36.64%   36.78%   +0.13%     
==========================================
  Files          33       33              
  Lines        1438     1441       +3     
==========================================
+ Hits          527      530       +3     
  Misses        822      822              
  Partials       89       89              
Impacted Files Coverage Δ
pkg/build/limit.go 62.50% <ø> (ø)
pkg/build/recorder.go 100.00% <ø> (ø)
pkg/build/shared.go 100.00% <ø> (ø)
pkg/commands/publisher.go 0.00% <0.00%> (ø)
pkg/build/gobuild.go 58.15% <80.00%> (+0.29%) ⬆️
pkg/internal/testing/fixed.go 69.56% <100.00%> (+1.38%) ⬆️
pkg/resolve/resolve.go 68.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde2582...0f4dfc8. Read the comment docs.

Copy link
Collaborator

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've wanted this forever, but without strict it was prohibitively noisy. Sooooo glad to see this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants