Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually print errors during resolve #275

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Actually print errors during resolve #275

merged 1 commit into from
Dec 21, 2020

Conversation

jonjohnsonjr
Copy link
Collaborator

We were just throwing away the error for ko resolve.

Follow-up to #233

@jonjohnsonjr
Actually print errors during resolve
c9575bf 
We were just throwing away the error for `ko resolve`.
@google-cla google-cla bot added the cla: yes label Dec 21, 2020
@jonjohnsonjr jonjohnsonjr merged commit fd5cd4b into ko-build:master Dec 21, 2020
@jonjohnsonjr jonjohnsonjr deleted the print-errors branch December 21, 2020 22:51
@jonjohnsonjr jonjohnsonjr mentioned this pull request Jan 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

Assignees

@imjasonh imjasonh

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonjohnsonjr @mattmoor @imjasonh