Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] upgrade to Go 1.17 everywhere, clean up configs #445

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

imjasonh
Copy link
Member

  • module integration test now runs with 1.16 and 1.17, and drops an unnecessary matrix value.
  • drop unnecessary step names (e.g., "Set up Go 1.17.x", which is redundant with the step config, and will only fall out of date and confuse people), and shell:bash (bash is the default value)

@imjasonh
Copy link
Member Author

gofmt in Go 1.17+ adds //go:build lines corresponding to // +build lines it sees, which is causing the diff. This change is backward compatible for pre-1.17, so we could just gofmt with Go 1.17 to get those lines.

This could be annoying if users are adding new // +build lines and gofmt'ing with Go <1.17, but I don't think that's too likely, and the mitigation is simple -- upgrade your Go version.

wdyt?

@jonjohnsonjr
Copy link
Collaborator

I'm ok with deleting the 1.13 thing?

This could be annoying if users

This is for contributors to ko, right? I think that's fine.

@imjasonh
Copy link
Member Author

#446 drops <1.13 support, which is nice because I can't get the boilerplate check to pass with it anyway. 🤷

@codecov-commenter
Copy link

Codecov Report

Merging #445 (53344f9) into main (08c6c71) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   53.25%   53.25%           
=======================================
  Files          37       37           
  Lines        1842     1842           
=======================================
  Hits          981      981           
  Misses        710      710           
  Partials      151      151           
Impacted Files Coverage Δ
pkg/build/trimpath_113.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c6c71...53344f9. Read the comment docs.

@imjasonh imjasonh merged commit 5a8663b into ko-build:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants