Produce OCI images by default #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
force-pushed
the
ocify-again
branch
2 times, most recently
from
60aac02 to
2d95d33
Compare
jonjohnsonjr
reviewed
Mar 3, 2022
This changes build logic to prefer to produce OCI images and indexes, even if original base images are Docker manifests or manifest lists. OCI indexes support annotations, while Docker manifest lists do not, and we'd like to inject base image information in annotations wherever possible. Since Quay.io recently added support for OCI manifests, this is no longer a serious breaking change -- and anyway, producing SBOMs by default already breaks Quay.io without --sbom=none. This behavior can be disabled with --preserve-docker-media-type=true, which will result in Docker-type manifests being produced if and only if the base image was a Docker-typed manifest. This partially reverts commit 42723d7.
jonjohnsonjr
approved these changes
Mar 4, 2022
imjasonh
added a commit
to imjasonh/ko
that referenced
this pull request
Mar 17, 2022
This reverts commit 7e9709a.
imjasonh
added a commit
that referenced
this pull request
Mar 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes build logic to prefer to produce OCI images and indexes,
even if original base images are Docker manifests or manifest lists.
OCI indexes support annotations, while Docker manifest lists do not, and
we'd like to inject base image information in annotations wherever possible.
Since Quay.io recently added support for OCI manifests, this is no
longer a serious breaking change -- and anyway, producing SBOMs by default
already breaks Quay.io without --sbom=none.
This behavior can be disabled with --preserve-docker-media-type=true,
which will result in Docker-type manifests being produced if and only if
the base image was a Docker-typed manifest.
This partially reverts commit 42723d7.