Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Produce OCI images by default (#623)" #653

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

imjasonh
Copy link
Member

This reverts commit 7e9709a

This change causes breakages when pushing to Quay.io, the fix for which (#641) causes mysterious errors in KinD.

Until we understand the compatibility story better, let's revert and unblock a v0.11 release to better support Go 1.18.

@imjasonh imjasonh requested a review from mattmoor March 17, 2022 12:45
@codecov-commenter
Copy link

Codecov Report

Merging #653 (f41293f) into main (3cf55a1) will decrease coverage by 0.27%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   51.89%   51.62%   -0.28%     
==========================================
  Files          44       44              
  Lines        3293     3268      -25     
==========================================
- Hits         1709     1687      -22     
+ Misses       1373     1371       -2     
+ Partials      211      210       -1     
Impacted Files Coverage Δ
pkg/build/options.go 68.75% <ø> (-1.84%) ⬇️
pkg/commands/options/build.go 68.86% <ø> (-0.86%) ⬇️
pkg/commands/resolver.go 32.98% <ø> (-0.24%) ⬇️
pkg/build/gobuild.go 61.64% <60.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf55a1...f41293f. Read the comment docs.

@imjasonh imjasonh requested a review from jonjohnsonjr March 17, 2022 16:21
@imjasonh imjasonh merged commit aafd3e8 into ko-build:main Mar 18, 2022
@sonatard sonatard mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants