Target multiple architectures #28
Conversation
See this blogpost for more on how this works: https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/
Error while copy pasting...
|
Hi, I've updated the CI workflow so that it runs on pull requests also. |
|
Ah, I see. There needs to be a special "builder" (read: profile) selected. I probably did this already on my machine. If you can push to this branch, just prepend I am currently on vacation without a PC, but in ~ 2 weeks I could do it. By the way, I forgot to mention, this will probably increase minute usage of the builds. |
This step is necessary to build multiarch images. More information here: https://docs.docker.com/docker-for-mac/multi-arch/#build-and-run-multi-architecture-images
|
Hmm... I tired some more and almost got it working, but this error is throwing me off: I'll be working on isolating the problem. Not on this PR though, in order to (1) not use up your build minutes 😉 and (2) not mess up your git history. One can follow my progress on the multi-arch-testing branch |
|
Ok thanks 😄 ! Thanks for your help ! |
Blocked by #21I will close this issue for the time being, until #21 is resolved. We're blocked by the cypress e2e testing framewrok. See this comment: #21 (comment) |
Filius-Patris
changed the title
* Revert and fix commit 3198879 Commit 3198879 prepended the CYPRESS_INSTALL_BINARY=0 variable to the install command in the ressources/assets directory, however this component does not require cypress. The root component however does. This environment variable should be prepended to the second install command. * Add 'install buildx' step This is just blindly following this blogpost: https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/ * Target multiple architectures See this blogpost for more on how this works: https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/ * Add python2 dependency to front-builder This error message shows it: https://github.com/Filius-Patris/docker-koel/runs/915997770?check_suite_focus=true#step:5:8914 This issue comment suggests why: sass/node-sass#1176 (comment) TL;DR: Building some component requires python. This would normally be precompiled and fetched, but arm doesn't have precompiled packages. * Increase network timeout The CICD errors seems to be tied to this: yarnpkg/yarn#4890 (comment) * Try building the 3 architectures at the end of the CI. This is meant to test the CI. If it works, it will be done in publish.yml instead of dockerimage.yml. * Update CI/CD pipelines For more details, see the discussions on PR #31. With this commit, some targets in the Makefile are unneeded, but I left them anyway. * Correcting the tags: argument I wasn't understanding the docs correctly. * Refine CI/CD pipelines more With this commit the pipeline completely cut reliance to the Makefile. This helps to make everything more obvious by only looking at the pipeline yaml file. Co-authored-by: Joris MASSON <hyzual@gmail.com>
@Hyzual could you please run the pipeline? I'm not 100% sure if it works correctly. I ran it locally and I think it worked...
Tagging issue #21.