Revert and fix commit 3198879 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3198879 prepended the CYPRESS_INSTALL_BINARY=0 variable to the install command in the ressources/assets directory, however this component does not require cypress. The root component however does. This environment variable should be prepended to the second install command.
|
Nice catch, indeed I made a dumb mistake and added the env variable on the wrong line 😅 . Thanks a lot for investigating and fixing it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3198879 prepended the
CYPRESS_INSTALL_BINARY=0variable tothe install command in the ressources/assets directory, however
this component does not require cypress.
The root component however does. This environment variable should
be prepended to the second install command.
PR #28 is based on this branch.