Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated CPP files moving includes inside the ifdef's #199

Closed
mndevec opened this issue Mar 29, 2018 · 3 comments
Closed

Generated CPP files moving includes inside the ifdef's #199

mndevec opened this issue Mar 29, 2018 · 3 comments
Assignees
@crtrott @mndevec
Labels
enhancement InDevelop

Comments

@mndevec
Copy link
Contributor

mndevec commented Mar 29, 2018

As suggested by @ibaned : many of the generated cpp files are not compiled, yet they have includes that are not protected by the ifdef macros.

For example:
https://github.com/kokkos/kokkos-kernels/blob/master/src/impl/generated_specializations_cpp/abs/KokkosBlas1_abs_eti_spec_inst_Kokkos_complex_double__LayoutLeft_Cuda_CudaSpace.cpp

Moving "#ifdef" macros outside so that they wrap "#include ..." might reduce the compile time further.
@srajama1
Copy link
Contributor

Can we change the generator too ?

@crtrott
Copy link
Member

crtrott commented Mar 30, 2018

Yeah we should change the generator. I look into it.

mndevec added a commit to mndevec/kokkos-kernels that referenced this issue Apr 5, 2018
@mndevec
Moving includes inside the ifdefs in generated cpp files.
00592b1 
Related to kokkos#199.

Compilation on white with single lno, size_type and scalar_type and two execution spaces.
--previously took 3m 55s
--after changes suggested by @ibaned reduced to 3m 35 s.
@mndevec mndevec mentioned this issue Apr 5, 2018
Closed
mndevec added a commit to mndevec/kokkos-kernels that referenced this issue Apr 5, 2018
@mndevec
Related to kokkos#199.
6ffb076 
Compilation on white with single lno, size_type and scalar_type and two execution spaces.
--previously took 5m 18s
--after changes suggested by @ibaned reduced to 4m 21 s.
@mndevec mndevec mentioned this issue Apr 5, 2018
Merged
@ndellingwood
Copy link
Contributor

PR #203

@ndellingwood ndellingwood mentioned this issue May 25, 2018
Merged
@kokkos-devops-admin kokkos-devops-admin mentioned this issue Sep 27, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

@mndevec mndevec

Labels
enhancement InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crtrott @srajama1 @ndellingwood @mndevec