-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving includes inside ifdefs #203
Conversation
Compilation on white with single lno, size_type and scalar_type and two execution spaces. --previously took 5m 18s --after changes suggested by @ibaned reduced to 4m 21 s.
Spot-check running on kokkos-dev |
Spot-check passes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes spot-check, script changes look correct.
Nathan, did you time the compilation? |
@mndevec I reran the spot-check with this PR and with the prior commit when the machine wasn't busy to get better comparison for times, nice improvements :) Spot-check results with this PR:
Spot check results with commit prior to this PR including build times
|
Thanks @ndellingwood and @ibaned ! |
@ndellingwood , @crtrott , @srajama1 |
Related to #199.
Compilation on white with single lno, size_type and scalar_type and two execution spaces.
--previously took 5m 18s
--after changes suggested by @ibaned: reduced to 4m 21 s.