ineffassign

kolide · Feb 1, 2024 · c79e3c2 · c79e3c2
1 parent 3c9247a
commit c79e3c2
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/pkg/osquery/table/program_icons_windows.go b/pkg/osquery/table/program_icons_windows.go
@@ -61,6 +61,9 @@ func generateUninstallerProgramIcons() []map[string]string {
 			defer key.Close()
 
 			iconPath, _, err := key.GetStringValue("DisplayIcon")
+			if err != nil {
+				continue
+			}
 			icon, err := parseIcoFile(iconPath)
 			if err != nil {
 				continue
@@ -99,6 +102,9 @@ func generateInstallersProgramIcons() []map[string]string {
 			defer key.Close()
 
 			iconPath, _, err := key.GetStringValue("ProductIcon")
+			if err != nil {
+				continue
+			}
 			icon, err := parseIcoFile(iconPath)
 			if err != nil {
 				continue
@@ -126,6 +132,9 @@ func generateInstallersProgramIcons() []map[string]string {
 func parseIcoFile(fullPath string) (icon, error) {
 	var programIcon icon
 	expandedPath, err := registry.ExpandString(fullPath)
+	if err != nil {
+		return programIcon, err
+	}
 	icoReader, err := os.Open(expandedPath)
 	if err != nil {
 		return programIcon, err