-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table exec's should use tablehelpers.Exec
#1321
Comments
I think this really means pushing the dataflatten stuff to use |
Fixes: kolide#1321 We have a nice exec helper. This should use it.
tablehelpers.Exec
I think this had been blocked on adding |
If I understand correctly, the issue suggests that we lint using forbigo to ensure that code with in the |
We should evaulate it in other places. Either exclude, or move to the helper, depending |
We have a couple places we create tables by parsing the output from execs. These should all use our helper. This achieves several goals:
We should:
cmd.Run
invocations and replace them withtablehelpers.Exec
(there may be some exceptions.execwrapper
and build generators for example)forbidigo
rule to lint for themThe text was updated successfully, but these errors were encountered: