tables use tablehelpers.run #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
changed the title
RebeccaMahany
previously approved these changes
May 1, 2024
James-Pickett
commented
May 3, 2024
ee/tables/dism_default_associations/dism_default_associations.go
Outdated
Show resolved
Hide resolved
James-Pickett
commented
May 3, 2024
James-Pickett
commented
May 6, 2024
James-Pickett
changed the title
James-Pickett
commented
May 6, 2024
| func Exec(ctx context.Context, slogger *slog.Logger, timeoutSeconds int, execCmd allowedcmd.AllowedCommand, args []string, includeStderr bool, opts ...ExecOps) ([]byte, error) { | ||
| // This is not suitable for high performance work -- it allocates new buffers each time | ||
| // Use Run() for more control over the stdout and stderr streams. | ||
| func RunSimple(ctx context.Context, slogger *slog.Logger, timeoutSeconds int, cmd allowedcmd.AllowedCommand, args []string, opts ...ExecOps) ([]byte, error) { |
There was a problem hiding this comment.
still not 100% sold on the functions .... wonder if we should make an option for WithStderr(w io.Writer)
There was a problem hiding this comment.
TBH I'm not 100% sure either. But I think this is a great step, and we can refactor if it feels wrong.
RebeccaMahany
previously approved these changes
May 6, 2024
directionless
previously approved these changes
May 7, 2024
James-Pickett
dismissed stale reviews from directionless and RebeccaMahany
via
eaba943
directionless
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1321
Adds helper functions to enforce timeout and simplify creating / execing commands. Follow on PR will add linting.