Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip tests legacy autoupdate tests in CI #1701

Merged
merged 1 commit into from
May 1, 2024
Merged

Skip tests legacy autoupdate tests in CI #1701

merged 1 commit into from
May 1, 2024

Conversation

RebeccaMahany
Copy link
Contributor

  1. We are not modifying the legacy autoupdate code anymore, so we don't need the tests to validate against regressions
  2. After the next launcher release, we are going to remove the legacy autoupdate code altogether (Remove the rest of pkg/autoupdate #1679)
  3. These tests are some of our flakiest

James-Pickett
James-Pickett approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@James-Pickett James-Pickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🎉

@RebeccaMahany RebeccaMahany enabled auto-merge May 1, 2024 15:27
@RebeccaMahany RebeccaMahany added this pull request to the merge queue May 1, 2024
Merged via the queue into kolide:main with commit 3a6bc13 May 1, 2024
30 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/skip-legacy-autoupdate-tests branch May 1, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackattack01 zackattack01 zackattack01 approved these changes

@James-Pickett James-Pickett James-Pickett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RebeccaMahany @James-Pickett @zackattack01