Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests legacy autoupdate tests in CI #1701

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions pkg/autoupdate/findnew_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ import (
func TestFindNewestSelf(t *testing.T) {
t.Parallel()

// These tests will be deleted in https://github.com/kolide/launcher/pull/1679
// after the next stable release.
if os.Getenv("CI") != "" {
t.Skip("skipping flaky and soon-to-be-deleted tests in CI")
}

ctx := context.TODO()

{
Expand Down Expand Up @@ -113,6 +119,12 @@ func TestFindBaseDir(t *testing.T) {
func TestFindNewestEmpty(t *testing.T) {
t.Parallel()

// These tests will be deleted in https://github.com/kolide/launcher/pull/1679
// after the next stable release.
if os.Getenv("CI") != "" {
t.Skip("skipping flaky and soon-to-be-deleted tests in CI")
}

tmpDir, binaryName := setupTestDir(t, emptySetup)
ctx := context.TODO()
binaryPath := filepath.Join(tmpDir, binaryName)
Expand All @@ -126,6 +138,12 @@ func TestFindNewestEmpty(t *testing.T) {
func TestFindNewestEmptyUpdateDirs(t *testing.T) {
t.Parallel()

// These tests will be deleted in https://github.com/kolide/launcher/pull/1679
// after the next stable release.
if os.Getenv("CI") != "" {
t.Skip("skipping flaky and soon-to-be-deleted tests in CI")
}

tmpDir, binaryName := setupTestDir(t, emptyUpdateDirs)
ctx := context.TODO()
binaryPath := filepath.Join(tmpDir, binaryName)
Expand Down Expand Up @@ -164,6 +182,12 @@ func TestFindNewestNonExecutable(t *testing.T) {
func TestFindNewestExecutableUpdates(t *testing.T) {
t.Parallel()

// These tests will be deleted in https://github.com/kolide/launcher/pull/1679
// after the next stable release.
if os.Getenv("CI") != "" {
t.Skip("skipping flaky and soon-to-be-deleted tests in CI")
}

tmpDir, binaryName := setupTestDir(t, executableUpdates)
ctx := context.TODO()
binaryPath := filepath.Join(tmpDir, binaryName)
Expand All @@ -184,6 +208,12 @@ func TestFindNewestExecutableUpdates(t *testing.T) {
func TestFindNewestCleanup(t *testing.T) {
t.Parallel()

// These tests will be deleted in https://github.com/kolide/launcher/pull/1679
// after the next stable release.
if os.Getenv("CI") != "" {
t.Skip("skipping flaky and soon-to-be-deleted tests in CI")
}

// delete doesn't seem to work on windows. It gets a
// "Access is denied" error". This may be a test setup
// issue, or something with an open file handle.
Expand Down Expand Up @@ -223,6 +253,12 @@ func TestFindNewestCleanup(t *testing.T) {
func TestCheckExecutableCorruptCleanup(t *testing.T) {
t.Parallel()

// These tests will be deleted in https://github.com/kolide/launcher/pull/1679
// after the next stable release.
if os.Getenv("CI") != "" {
t.Skip("skipping flaky and soon-to-be-deleted tests in CI")
}

tmpDir, binaryName := setupTestDir(t, truncatedUpdates)
ctx := context.TODO()
binaryPath := filepath.Join(tmpDir, binaryName)
Expand Down
Loading