Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KATC] Prepare ee/indexeddb for use in KATC tables #1767

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

RebeccaMahany
Copy link
Contributor

Now that we have a KATC implementation here, we can prepare to implement an indexeddb_leveldb source type. This PR updates the ee/indexeddb package in preparation for KATC usage by doing the following:

  • Remove data that we now know is superfluous (indexeddb key, indexeddb version)
  • Rename deserializeIndexeddbValue deserialization function for consistency with deserializeFirefox
  • Separate out the data retrieval function (QueryIndexeddbObjectStore) and transformation function (now deserializeChrome), and update their method signatures, so that they can become a katcSourceType.dataFunc and rowTransformStep.transformFunc, respectively

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Jul 2, 2024
Merged via the queue into kolide:main with commit 36afc33 Jul 2, 2024
30 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/katc-leveldb-prep branch July 2, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants