[KATC] Add support for .indexeddb.leveldb files #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on previous work (#1767, #1763) to add support for querying Chrome extension data:
indexeddb_leveldbI am waffling on whether I should move the
ee/indexeddbcode into this package. Since bothindexeddb.QueryIndexeddbObjectStoreandindexeddb.DeserializeChromeadhere tokatc.katcSourceType.dataFuncandkatc.rowTransformStep.transformFunc, respectively, it seems to make more sense for that code to live inside this package -- and we don't currently have any other usecases for interacting with indexeddb otherwise. I'd like to get folks' thoughts on this question -- if we do want to move the code, I'll do it in a follow-up PR to keep these simple/reviewable!Additionally, fixed an issue where underscores in filepaths were treated as single-char wildcards; we don't need to support this functionality, so I just removed it.