-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RELEASE-1191): differentiate pyxis and umb in signing #729
Conversation
Skipping CI for Draft Pull Request. |
8576c92
to
78e33a4
Compare
/ok-to-test |
This PR is ready for review. It is in draft status because I don't want to merge it yet. I don't want to put it in the same promotion cycle as #723 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
78e33a4
to
4511915
Compare
4511915
to
5a32ff7
Compare
/retest |
E2E is failing here because it uses the |
Depends on #734 |
5a32ff7
to
6fd7788
Compare
I see you rebased this already (on top of merged #734 ). Shall I review it now? Let me know. |
Yeah I think it should be good to go |
/retest |
This commit modifies the tasks used in `simple-signing-pipeline` to separate credentials for Pyxis and UMB authentication. Prior to this commit, both were pulled from the same configMap values so it was impossible to use stage for one system and prod for the other. Signed-off-by: Johnny Bieren <jbieren@redhat.com>
6fd7788
to
7e1fe00
Compare
@johnbieren: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-px5rw |
This commit modifies the tasks used in
simple-signing-pipeline
to use separate credentials for Pyxis and UMB authentication. Prior to this commit, both were pulled from the same configMap values so it was impossible to use stage for one system and prod for the other.