Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-1191): differentiate pyxis and umb in signing #729

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

johnbieren
Copy link
Collaborator

@johnbieren johnbieren commented Dec 5, 2024

This commit modifies the tasks used in simple-signing-pipeline to use separate credentials for Pyxis and UMB authentication. Prior to this commit, both were pulled from the same configMap values so it was impossible to use stage for one system and prod for the other.

Copy link

openshift-ci bot commented Dec 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@johnbieren johnbieren force-pushed the release1191_3 branch 2 times, most recently from 8576c92 to 78e33a4 Compare December 5, 2024 19:36
@johnbieren
Copy link
Collaborator Author

/ok-to-test

@johnbieren johnbieren requested a review from a team December 5, 2024 19:40
@johnbieren
Copy link
Collaborator Author

This PR is ready for review. It is in draft status because I don't want to merge it yet. I don't want to put it in the same promotion cycle as #723

@johnbieren johnbieren requested a review from scoheb December 5, 2024 19:42
mmalina
mmalina previously approved these changes Dec 5, 2024
Copy link
Contributor

@mmalina mmalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@johnbieren
Copy link
Collaborator Author

/retest

@johnbieren
Copy link
Collaborator Author

E2E is failing here because it uses the simple-signing-pipeline on the stage cluster. This pipeline definition has task git resolvers, but it does not pass the new parameters to the tasks because it is the old pipeline definition, not the one from this PR. That is because IRs don't use git resolvers (yet) for executing pipelineRuns. So, I'd have to change the simple-signing-pipeline first, merge it, then run e2e for this PR. That should work, but it has to be part of the same promotion cycle or we will run into issues

@johnbieren
Copy link
Collaborator Author

Depends on #734

@mmalina
Copy link
Contributor

mmalina commented Dec 9, 2024

I see you rebased this already (on top of merged #734 ). Shall I review it now? Let me know.

@johnbieren
Copy link
Collaborator Author

I see you rebased this already (on top of merged #734 ). Shall I review it now? Let me know.

Yeah I think it should be good to go

@johnbieren johnbieren marked this pull request as ready for review December 9, 2024 12:59
@johnbieren
Copy link
Collaborator Author

/retest

This commit modifies the tasks used in `simple-signing-pipeline` to
separate credentials for Pyxis and UMB authentication. Prior to this
commit, both were pulled from the same configMap values so it was
impossible to use stage for one system and prod for the other.

Signed-off-by: Johnny Bieren <jbieren@redhat.com>
@johnbieren johnbieren enabled auto-merge (squash) December 10, 2024 12:18
@openshift-ci openshift-ci bot added the lgtm label Dec 10, 2024
@johnbieren johnbieren disabled auto-merge December 10, 2024 12:34
@johnbieren johnbieren merged commit eb7b4f9 into konflux-ci:development Dec 10, 2024
7 of 8 checks passed
@johnbieren johnbieren deleted the release1191_3 branch December 10, 2024 12:34
@konflux-ci-qe-bot
Copy link

@johnbieren: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-tests-catalog-px5rw Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-px5rw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants