Require user to supply --convert-to-dataset-format #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... or, sometimes, --no-convert-to-dataset-format --convert-to-dataset-format: the user acknowledges that the tiles as they are don't comply to the dataset format constraint. Kart is allowed to convert them during commit so that they do. In practise, the conversions will be any of: make cloud optimized change laz version (eg LAZ 1.2 to LAZ 1.4) --no-convert-to-dataset-format: the user acknowledges that the tiles as they are don't comply to the dataset format constraint. Kart is allowed to update the dataset format so that they do. In practice the update will be: - drop cloud optimized constraint - change laz format of entire dataset (only allowed if every new tile conforms to the new format)
olsen232
force-pushed
the
diff-commit-prompts
branch
from
50a28fa
to
4e72dc9
Compare
craigds
approved these changes
May 24, 2023
kart/base_diff_writer.py
Outdated
| self.write_pk_conflicts_warning_footer() | ||
| self.write_list_of_conflicts_warning_footer() | ||
|
|
||
| def write_pk_conflicts_warning_footer(self): |
There was a problem hiding this comment.
are 'PK conflicts' always 'spatial filter conflicts' and vice versa? I'd suggest renaming consistently to the latter (it's the most descriptive) rather than using two names
kart/point_cloud/v1.py
Outdated
| merged_format.error_message = "Committing LAS tiles is not supported, unless you specify the --convert-to-dataset-format flag" | ||
| merged_metadata["format.json"] = merged_format | ||
|
|
||
| def is_cloud_optimized(self): | ||
| return self.get_meta_item("format.json").get("optimization") == "copc" | ||
| def _ensure_list(self, arg): |
There was a problem hiding this comment.
Used in one place - I'll inline it to where it's used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... or, sometimes, --no-convert-to-dataset-format
--convert-to-dataset-format: the user acknowledges that the tiles as they are don't comply to the dataset format constraint. Kart is allowed to convert them during commit so that they do. In practise, the conversions will be any of:
make cloud optimized
change laz version (eg LAZ 1.2 to LAZ 1.4)
--no-convert-to-dataset-format: the user acknowledges that the tiles as they are don't comply to the dataset format constraint. Kart is allowed to update the dataset format so that they do. In practice the update will be:
This also updates
kart diffto better explain these type of errors: until now, they were shown as conflicts with <<<, >>> markers, but the associated error message isn't shown until youkart commit. Butkart diffwill now also show these warnings.#842
Checklist: