koordlet: skip the container which is not running in cpuBurst applyC…

…FSQuotaBurst (#2055) Signed-off-by: yangfeiyu <yangfeiyu20102011@163.com>
koordinator-sh · May 22, 2024 · e6ae456 · e6ae456
1 parent eed98fa
commit e6ae456
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/pkg/koordlet/qosmanager/plugins/cpuburst/cpu_burst.go b/pkg/koordlet/qosmanager/plugins/cpuburst/cpu_burst.go
@@ -355,6 +355,11 @@ func (b *cpuBurst) applyCFSQuotaBurst(burstCfg *slov1alpha1.CPUBurstConfig, podM
 			continue
 		}
 
+		if containerStat.State.Running == nil {
+			klog.V(6).Infof("skip container %s/%s/%s, because it is not running", pod.Namespace, pod.Name, containerStat.Name)
+			continue
+		}
+
 		containerBaseCFS := koordletutil.GetContainerBaseCFSQuota(container)
 		if containerBaseCFS <= 0 {
 			continue

diff --git a/pkg/koordlet/qosmanager/plugins/cpuburst/cpu_burst_test.go b/pkg/koordlet/qosmanager/plugins/cpuburst/cpu_burst_test.go
@@ -149,6 +149,7 @@ func newTestPodWithQOS(name string, qos apiext.QoSClass, cpuMilli, memoryBytes i
 				{
 					Name:        containerName,
 					ContainerID: genTestContainerIDByName(containerName),
+					State:       corev1.ContainerState{Running: &corev1.ContainerStateRunning{}},
 				},
 			},
 			Phase: corev1.PodRunning,
@@ -233,6 +234,7 @@ func createPodMetaByResource(podName string, containersRes map[string]corev1.Res
 		containerStat := corev1.ContainerStatus{
 			Name:        containerName,
 			ContainerID: genTestContainerIDByName(containerName),
+			State:       corev1.ContainerState{Running: &corev1.ContainerStateRunning{}},
 		}
 		pod.Spec.Containers = append(pod.Spec.Containers, container)
 		pod.Status.ContainerStatuses = append(pod.Status.ContainerStatuses, containerStat)