Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: skip the container which is not running in cpuBurst applyCFSQuotaBurst #2055

Merged
merged 1 commit into from
May 22, 2024

Conversation

yangfeiyu20102011
Copy link
Contributor

Some containers are not running, maybe they have failed, just skip them.
It can also reduce the confusing err msgs.

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.59%. Comparing base (eed98fa) to head (459de42).

Files Patch % Lines
.../koordlet/qosmanager/plugins/cpuburst/cpu_burst.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
+ Coverage   68.56%   68.59%   +0.02%     
==========================================
  Files         430      430              
  Lines       39383    39386       +3     
==========================================
+ Hits        27004    27016      +12     
+ Misses      10043    10038       -5     
+ Partials     2336     2332       -4     
Flag Coverage Δ
unittests 68.59% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…SQuotaBurst

Some containers are not running, maybe they have failed, just skip them.
It can also reduce the confusing err msgs.

Signed-off-by: yangfeiyu <yangfeiyu20102011@163.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e6ae456 into koordinator-sh:main May 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants