Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network QoS: more validation for config #1866

Closed
zwzhang0107 opened this issue Jan 24, 2024 · 1 comment
Closed

Network QoS: more validation for config #1866

zwzhang0107 opened this issue Jan 24, 2024 · 1 comment
Labels
area/koord-manager good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v1.5

Comments

@zwzhang0107
Copy link
Contributor

besides the format, there are more things need to check:

  1. sum(NetworkQOS.request) < 100% or TotalNetworkBandwidth, at least leave some for system overhead
  2. NetworkQOS.limit < TotalNetworkBandwidth
  3. percent and absolute value cannot be used at the same time

Originally posted by @zwzhang0107 in #1841 (comment)
@zwzhang0107 zwzhang0107 added good first issue Good for newcomers help wanted Extra attention is needed area/koord-manager labels Jan 24, 2024
@zwzhang0107
Copy link
Contributor Author

cc @lucming

@lucming lucming mentioned this issue Jan 30, 2024
Merged
3 tasks
@saintube saintube added this to the v1.5 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/koord-manager good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v1.5
Development

No branches or pull requests
3 participants
@ZiMengSheng @saintube @zwzhang0107