Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: validate network qos config in webhook #1841

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

lucming
Copy link
Contributor

@lucming lucming commented Jan 15, 2024

Ⅰ. Describe what this PR does

add some logic to verify netqos config is valid

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (7c7a844) 67.02% compared to head (97669ab) 67.26%.
Report is 22 commits behind head on main.

Files Patch % Lines
...bhook/cm/plugins/sloconfig/resource_qos_checker.go 58.44% 23 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
+ Coverage   67.02%   67.26%   +0.23%     
==========================================
  Files         407      411       +4     
  Lines       45553    45848     +295     
==========================================
+ Hits        30534    30839     +305     
+ Misses      12792    12774      -18     
- Partials     2227     2235       +8     
Flag Coverage Δ
unittests 67.26% <58.44%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107 zwzhang0107 changed the title webhook: check netqos config koord-manager: validate network qos config in webhook Jan 16, 2024
@zwzhang0107
Copy link
Contributor

besides the format, there are more things need to check:

  1. sum(NetworkQOS.request) < 100% or TotalNetworkBandwidth, at least leave some for system overhead
  2. NetworkQOS.limit < TotalNetworkBandwidth
  3. percent and absolute value cannot be used at the same time

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@zwzhang0107
Copy link
Contributor

/assign @eahydra

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eahydra eahydra changed the title koord-manager: validate network qos config in webhook webhook: validate network qos config in webhook Jan 26, 2024
Signed-off-by: lucming <2876757716@qq.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Jan 26, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 22ffeec into koordinator-sh:main Jan 26, 2024
20 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants