-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook: validate network qos config in webhook #1841
webhook: validate network qos config in webhook #1841
Conversation
8ad70b0
to
e5dfa82
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
==========================================
+ Coverage 67.02% 67.26% +0.23%
==========================================
Files 407 411 +4
Lines 45553 45848 +295
==========================================
+ Hits 30534 30839 +305
+ Misses 12792 12774 -18
- Partials 2227 2235 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
besides the format, there are more things need to check:
|
/lgtm |
/assign @eahydra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
e5dfa82
to
c93869f
Compare
Signed-off-by: lucming <2876757716@qq.com>
c93869f
to
97669ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: lucming <2876757716@qq.com>
Ⅰ. Describe what this PR does
add some logic to verify netqos config is valid
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test