Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: more checks for netqos #1878

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

lucming
Copy link
Contributor

@lucming lucming commented Jan 30, 2024

Ⅰ. Describe what this PR does

ralated issue: #1866

The absolute value scenario is not handled, because it requires the actual network bandwidth of the node, which is not yet available here

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (a056ccb) 67.26% compared to head (f0d5309) 67.56%.
Report is 5 commits behind head on main.

Files Patch % Lines
...bhook/cm/plugins/sloconfig/resource_qos_checker.go 68.58% 33 Missing and 16 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
+ Coverage   67.26%   67.56%   +0.30%     
==========================================
  Files         411      413       +2     
  Lines       45848    46206     +358     
==========================================
+ Hits        30838    31221     +383     
+ Misses      12778    12724      -54     
- Partials     2232     2261      +29     
Flag Coverage Δ
unittests 67.56% <68.58%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107
Copy link
Contributor

the node total bandwidth is configured at https://github.com/koordinator-sh/koordinator/blob/main/apis/slo/v1alpha1/nodeslo_types.go#L381
also, the absolute format and percent fomat cannot mix used.

@lucming
Copy link
Contributor Author

lucming commented Jan 30, 2024

the node total bandwidth is configured at https://github.com/koordinator-sh/koordinator/blob/main/apis/slo/v1alpha1/nodeslo_types.go#L381 also, the absolute format and percent fomat cannot mix used.

but nodeslo also relies on this configmap

@zwzhang0107
Copy link
Contributor

the node total bandwidth is configured at https://github.com/koordinator-sh/koordinator/blob/main/apis/slo/v1alpha1/nodeslo_types.go#L381 also, the absolute format and percent fomat cannot mix used.

but nodeslo also relies on this configmap

the struct is also imported in configmap https://github.com/koordinator-sh/koordinator/blob/main/apis/configuration/slo_controller_config.go#L88

@lucming lucming force-pushed the check-netqos branch 4 times, most recently from 6b1923b to ad5bdad Compare January 31, 2024 12:49
@lucming lucming changed the title webhook: check total percentage of net bandwidth cannot over 100 webhook: check total net bandwidth cannot over 100 or totalNetBandWidth Jan 31, 2024
@lucming lucming changed the title webhook: check total net bandwidth cannot over 100 or totalNetBandWidth webhook: check the sum of network bandwidth in all qos cannot over 100 or totalNetBandWidth Jan 31, 2024
@lucming lucming changed the title webhook: check the sum of network bandwidth in all qos cannot over 100 or totalNetBandWidth webhook: more checks for netqos Jan 31, 2024
@lucming lucming force-pushed the check-netqos branch 3 times, most recently from 4fb4a79 to 5ca3a47 Compare February 4, 2024 06:34
Signed-off-by: lucming <2876757716@qq.com>
@zwzhang0107
Copy link
Contributor

@eahydra PTAL

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d9c2971 into koordinator-sh:main Feb 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants