-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook: more checks for netqos #1878
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
==========================================
+ Coverage 67.26% 67.56% +0.30%
==========================================
Files 411 413 +2
Lines 45848 46206 +358
==========================================
+ Hits 30838 31221 +383
+ Misses 12778 12724 -54
- Partials 2232 2261 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the node total bandwidth is configured at https://github.com/koordinator-sh/koordinator/blob/main/apis/slo/v1alpha1/nodeslo_types.go#L381 |
but |
the struct is also imported in configmap https://github.com/koordinator-sh/koordinator/blob/main/apis/configuration/slo_controller_config.go#L88 |
6b1923b
to
ad5bdad
Compare
4fb4a79
to
5ca3a47
Compare
Signed-off-by: lucming <2876757716@qq.com>
@eahydra PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
ralated issue: #1866
The absolute value scenario is not handled, because it requires the actual network bandwidth of the
node
, which is not yet available hereⅡ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test