koord-scheduler: skip checking for nodes whose nodemetrics update time has expired #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucming
force-pushed
the
fix-loadaware-sched
branch
from
6ad7ed0 to
f76a7ee
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
+ Coverage 65.04% 65.20% +0.16%
==========================================
Files 352 352
Lines 36253 36326 +73
==========================================
+ Hits 23580 23686 +106
+ Misses 10931 10899 -32
+ Partials 1742 1741 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eahydra
changed the title
eahydra
reviewed
Aug 22, 2023
…tric is not updated for a long time Signed-off-by: liuming6 <liuming6@360.cn>
lucming
force-pushed
the
fix-loadaware-sched
branch
from
f76a7ee to
152613d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
j4ckstraw
pushed a commit
to j4ckstraw/koordinator
that referenced
this pull request
May 20, 2024
…e has expired (koordinator-sh#1563) Signed-off-by: liuming6 <liuming6@360.cn> Co-authored-by: liuming6 <liuming6@360.cn>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
In some cases,
nodemetricis not updated for a long time, eg: koordlet be deleted. which will result in nodemetric not being able to report, and if the latest load innodemetricis very high, it will result in the node not being able to run any pods, even if the actual load is very lowAt this point, the
loadawarescheduling plugin's calculations should not be counted in the final scheduling result, because the plugin strongly relies onnodemetricin filter phase: do not handle these nodes that nodemetric have not been updated for a long time
in score phase: score 0 and return directly
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test