koord-scheduler: add a parameter to mark whether scheduling is allowed on node with expired nodemetric #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucming
force-pushed
the
loadaware-enhance
branch
from
7df176f to
cc6262e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2076 +/- ##
==========================================
- Coverage 68.62% 68.58% -0.05%
==========================================
Files 430 430
Lines 39540 39639 +99
==========================================
+ Hits 27136 27188 +52
- Misses 10061 10097 +36
- Partials 2343 2354 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…d on node with expired nodemetric Signed-off-by: lucming <2876757716@qq.com>
lucming
force-pushed
the
loadaware-enhance
branch
from
cc6262e to
79f0893
Compare
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
add
enableScheduleWhenNodeMetricsExpiredparameter forloadawarescheduler plugin to mark whether scheduling is allowed on node with expired nodemetric.it be used to address the following issues：
nodemetricexpired：avoid pods being scheduled to nodes with high load.nodemetricexpired：the actual load of the node is very low but the nodemetric is very high. It may be blocked by thefilterphase, causing the node to be unable to schedule a new pod anymore. FYI: koord-scheduler: skip checking for nodes whose nodemetrics update time has expired #1563Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test