Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: support NetworkQoS based on external plugin such as terway-qos #1779

Merged
merged 1 commit into from
Jan 11, 2024
Merged

docs: support NetworkQoS based on external plugin such as terway-qos #1779

merged 1 commit into from
Jan 11, 2024

Conversation

lucming
Copy link
Contributor

@lucming lucming commented Dec 16, 2023

Ⅰ. Describe what this PR does

this is doc for netqos base on terway-qos. and there are some disscussion in #1764

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov Codecov
Copy link

codecov bot commented Dec 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (688cdd3) 66.30% compared to head (4dab977) 67.00%.
Report is 34 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
+ Coverage   66.30%   67.00%   +0.70%     
==========================================
  Files         394      407      +13     
  Lines       43330    45506    +2176     
==========================================
+ Hits        28730    30493    +1763     
- Misses      12464    12788     +324     
- Partials     2136     2225      +89
Flag Coverage Δ
unittests 67.00% <100.00%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107 zwzhang0107 changed the title doc: netqos based on terway-qos docs: support NetworkQoS based on external plugin such as terway-qos Dec 19, 2023
zwzhang0107
zwzhang0107 reviewed Dec 22, 2023
View reviewed changes
apis/slo/v1alpha1/nodeslo_types.go Outdated Show resolved Hide resolved
apis/slo/v1alpha1/nodeslo_types.go Outdated Show resolved Hide resolved
docs/proposals/koordlet/20231208-netqos-terway.md Outdated Show resolved Hide resolved
docs/proposals/koordlet/20231208-netqos-terway.md Outdated Show resolved Hide resolved
docs/proposals/koordlet/20231208-netqos-terway.md Outdated Show resolved Hide resolved
docs/proposals/koordlet/20231208-netqos-terway.md Outdated Show resolved Hide resolved
docs/proposals/koordlet/20231208-netqos-terway.md Outdated Show resolved Hide resolved
docs/proposals/koordlet/20231208-netqos-terway.md Outdated Show resolved Hide resolved
@zwzhang0107
Copy link
Contributor

now it's all good to me, what do you think @l1b0k :)

@zwzhang0107
Copy link
Contributor

some codes need to be regenereated

Error: #16 40.82 apis/slo/v1alpha1/zz_generated.deepcopy.go:874:11: undefined: PodNetworkQOS

@lucming lucming force-pushed the terway-qos-doc branch 2 times, most recently from b0ef4b5 to 3a9db05 Compare December 25, 2023 13:47
@lucming
Copy link
Contributor Author

lucming commented Dec 25, 2023

some codes need to be regenereated

Error: #16 40.82 apis/slo/v1alpha1/zz_generated.deepcopy.go:874:11: undefined: PodNetworkQOS

done

@lucming lucming mentioned this pull request Jan 2, 2024
Closed
3 tasks
@lujinda
Copy link

lujinda commented Jan 4, 2024

What is the network QoS guarantee for system components? For example containerd, kubelet, hostNetwork pod.Is design resource reservation necessary?

@lucming
Copy link
Contributor Author

lucming commented Jan 4, 2024

What is the network QoS guarantee for system components? For example containerd, kubelet, hostNetwork pod.Is design resource reservation necessary?

l0 priority will be given by default.

@zwzhang0107
Copy link
Contributor

zwzhang0107 commented Jan 5, 2024 •
edited
Loading

What is the network QoS guarantee for system components? For example containerd, kubelet, hostNetwork pod.Is design resource reservation necessary?

l0 priority will be given by default.

@lujinda yes, and there will be at least some guaranteed "quota" for l0 by default.

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jan 9, 2024
@koordinator-bot koordinator-bot bot removed the lgtm label Jan 10, 2024
@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jan 10, 2024
@hormes
Copy link
Member

hormes commented Jan 11, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, l1b0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a73557b into koordinator-sh:main Jan 11, 2024
20 checks passed
@l1b0k l1b0k mentioned this pull request Jan 16, 2024
Merged
3 tasks
bowen-intel pushed a commit to kangclzjc/koordinator that referenced this pull request Jan 16, 2024
@lucming @bowen-intel
docs: support NetworkQoS based on external plugin such as terway-qos (k…
23697c9 
…oordinator-sh#1779)

Signed-off-by: lucming <2876757716@qq.com>
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
@lucming @ls-2018
docs: support NetworkQoS based on external plugin such as terway-qos (k…
08f339c 
…oordinator-sh#1779)

Signed-off-by: lucming <2876757716@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l1b0k l1b0k l1b0k approved these changes

@lujinda lujinda lujinda left review comments

@ZiMengSheng ZiMengSheng ZiMengSheng left review comments

@zwzhang0107 zwzhang0107 zwzhang0107 left review comments

@eahydra eahydra Awaiting requested review from eahydra

@FillZpp FillZpp Awaiting requested review from FillZpp

@hormes hormes Awaiting requested review from hormes

Assignees

@zwzhang0107 zwzhang0107

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lucming @zwzhang0107 @lujinda @hormes @l1b0k @ZiMengSheng