Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: support NetworkQoS plugin #1843

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

l1b0k
Copy link
Contributor

@l1b0k l1b0k commented Jan 16, 2024

Ⅰ. Describe what this PR does

This pull request enhances the Koordlet by introducing a new NetQoS plugin.
Previous discuss at #1764 #1779.

This update includes the incorporation of two distinct interfaces: one for Koordlet and another for Terway-QoS.

This default is Koordlet , and it is not implemented yet.
The Terway-QoS plugin support three level priority 'L0', 'L1', 'L2', the mapping with koordinator qos is as follow.

Koordinator QoS Kubernetes QoS Terway QoS
SYSTEM -- L0
LSE Guaranteed L1
LSR Guaranteed L1
LS Guaranteed/Burstable L1
BE BestEffort L2

When specifying different levels of traffic limitations, only three levels of QoS configuration will be used: SYSTEM, LS, and BE.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@zwzhang0107 zwzhang0107 changed the title WIP: Network QoS koordlet: support NetworkQoS plugin Jan 16, 2024
@zwzhang0107 zwzhang0107 changed the title koordlet: support NetworkQoS plugin (WIP)koordlet: support NetworkQoS plugin Jan 16, 2024
@zwzhang0107
Copy link
Contributor

how about implement in runtime hooks so that we can reuse the reconcile and NRI hook(set network qos for during pod createing.

@l1b0k
Copy link
Contributor Author

l1b0k commented Jan 16, 2024

i would take a look

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: Patch coverage is 48.82353% with 174 lines in your changes are missing coverage. Please review.

Project coverage is 67.35%. Comparing base (7c7a844) to head (ba208d9).
Report is 50 commits behind head on main.

Files Patch % Lines
...koordlet/runtimehooks/hooks/terwayqos/terwayqos.go 40.89% 160 Missing and 12 partials ⚠️
pkg/koordlet/runtimehooks/hooks/terwayqos/types.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1843      +/-   ##
==========================================
+ Coverage   67.02%   67.35%   +0.33%     
==========================================
  Files         407      418      +11     
  Lines       45553    46734    +1181     
==========================================
+ Hits        30534    31480     +946     
- Misses      12792    12957     +165     
- Partials     2227     2297      +70     
Flag Coverage Δ
unittests 67.35% <48.82%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/koordlet/runtimehooks/hooks/terwayqos/terwayqos.go Outdated Show resolved Hide resolved
pkg/koordlet/runtimehooks/hooks/terwayqos/types.go Outdated Show resolved Hide resolved
apis/extension/constants.go Outdated Show resolved Hide resolved
pkg/koordlet/runtimehooks/hooks/terwayqos/terwayqos.go Outdated Show resolved Hide resolved
pkg/koordlet/runtimehooks/config.go Show resolved Hide resolved
@zwzhang0107
Copy link
Contributor

also, there is some work on slo-controller: convert network qos from configmap(slo-controller-config) to NodeSLO

@l1b0k l1b0k force-pushed the feat/qos branch 4 times, most recently from a3b0740 to 3fba523 Compare February 19, 2024 05:21
@zwzhang0107
Copy link
Contributor

it will be great if there are more ut added to hit the patch target:

codecov/patch — 14.88% of diff hit (target 70.00%)

@l1b0k l1b0k force-pushed the feat/qos branch 2 times, most recently from deef46c to 7754c07 Compare February 20, 2024 09:20
@zwzhang0107 zwzhang0107 changed the title (WIP)koordlet: support NetworkQoS plugin koordlet: support NetworkQoS plugin Feb 21, 2024
@lucming lucming mentioned this pull request Feb 23, 2024
3 tasks
Signed-off-by: l1b0k <libokang.dev@gmail.com>
@zwzhang0107
Copy link
Contributor

/lgtm

@zwzhang0107
Copy link
Contributor

/approve

@zwzhang0107
Copy link
Contributor

PTAL
/assign @FillZpp @jasonliu747

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: FillZpp, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 3390433 into koordinator-sh:main Mar 4, 2024
20 checks passed
@l1b0k l1b0k deleted the feat/qos branch March 4, 2024 03:45
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: l1b0k <libokang.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants