-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: tc plugin for netqos #1920
Conversation
7205dd1
to
fa87361
Compare
it will be great if you can add some implement details in doc about tc plugin https://github.com/koordinator-sh/koordinator/blob/main/docs/proposals/koordlet/20231208-support-netqos.md#internal-plugins |
write in this pr? |
278d46a
to
4f2060b
Compare
another one with only proposal is better |
03257aa
to
96ae4e0
Compare
done. and this is proposal pr: #1954 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1920 +/- ##
==========================================
- Coverage 68.66% 67.91% -0.75%
==========================================
Files 435 441 +6
Lines 40703 41521 +818
==========================================
+ Hits 27947 28200 +253
- Misses 10345 10894 +549
- Partials 2411 2427 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d190e52
to
8e2f1c0
Compare
05a8197
to
85a32a3
Compare
go mod tidy? |
e08de79
to
72148e2
Compare
code needs rebase |
eb5f2af
to
769d712
Compare
995b612
to
3f651af
Compare
Signed-off-by: lucming <2876757716@qq.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
632ef28
into
koordinator-sh:main
Signed-off-by: lucming <2876757716@qq.com>
Ⅰ. Describe what this PR does
A plugin for netqos, and based on tc.
other discussion: #1764
btw, there may be some duplicate defination with pr #1843 .
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test