Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: tc plugin for netqos #1954

Closed
wants to merge 2 commits into from

Conversation

lucming
Copy link
Contributor

@lucming lucming commented Mar 15, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hormes after the PR has been reviewed.
You can assign the PR to them by writing /assign @hormes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: lucming <2876757716@qq.com>
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (beaafa3) to head (34f2d87).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
+ Coverage   67.52%   67.55%   +0.03%     
==========================================
  Files         420      420              
  Lines       47040    47059      +19     
==========================================
+ Hits        31764    31791      +27     
+ Misses      12965    12958       -7     
+ Partials     2311     2310       -1     
Flag Coverage Δ
unittests 67.55% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucming lucming mentioned this pull request Mar 15, 2024
3 tasks
tc class add dev eth0 parent 1:1 classid 1:3 htb rate 300Mbit ceil 1000Mbit prio 1
tc class add dev eth0 parent 1:1 classid 1:4 htb rate 300Mbit ceil 1000Mbit prio 2
ipset create high_class hash:net
iptables -t mangle -A POSTROUTING -m set --match-set high_class src -j CLASSIFY --set-class 1:2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里多介绍几句原因吧

and then share the network bandwidth in this `tc` class. By default, each `tc` `class` can use up all the network bandwidth of the node.
there are three classes defined, `high_class`/`mid_class`/`low_class` , each of pods will be matched to a `tc` class.

![image](/docs/images/netqos-tc.jpg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后续可以考虑对入方向的支持

@lucming lucming force-pushed the netqos-tc-doc branch 6 times, most recently from bb01baa to 220e1ba Compare March 28, 2024 08:35
@lucming lucming closed this Mar 28, 2024
@lucming lucming deleted the netqos-tc-doc branch March 28, 2024 09:01
@lucming lucming restored the netqos-tc-doc branch March 28, 2024 09:01
@lucming lucming reopened this Mar 28, 2024
@lucming lucming closed this Mar 28, 2024
@zwzhang0107 zwzhang0107 mentioned this pull request Mar 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants