-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler : supports disable runtime quota #1839
scheduler : supports disable runtime quota #1839
Conversation
b083189
to
f86dc4e
Compare
f86dc4e
to
888a8af
Compare
eaf4264
to
13b9865
Compare
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
13b9865
to
cfebd3a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1839 +/- ##
==========================================
- Coverage 67.03% 67.01% -0.02%
==========================================
Files 407 407
Lines 45557 45741 +184
==========================================
+ Hits 30538 30655 +117
- Misses 12796 12847 +51
- Partials 2223 2239 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Ⅰ. Describe what this PR does
Runtime quota can solve the fairness problem at the Quota layer, but in some scenarios, such as AI model training scenarios, the job may not be able to run due to runtime quota. It is necessary to provide a switch to turn off this ability to deal with this scenario.
Ⅱ. Does this pull request fix one issue?
to #1780
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test