scheduler: ElasticQuota runtime is no longer calculated when not needed #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1855 +/- ##
==========================================
+ Coverage 67.07% 67.09% +0.01%
==========================================
Files 407 407
Lines 45705 45702 -3
==========================================
+ Hits 30658 30663 +5
+ Misses 12820 12812 -8
Partials 2227 2227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
disable_runtime_v2
branch
from
2a9f88d
to
143c18b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saintube
pushed a commit
to saintube/koordinator
that referenced
this pull request
Feb 22, 2024
…ed (koordinator-sh#1855) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube
pushed a commit
that referenced
this pull request
Feb 26, 2024
…ed (#1855) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube
pushed a commit
to saintube/koordinator
that referenced
this pull request
Feb 26, 2024
…ed (koordinator-sh#1855) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube
pushed a commit
to saintube/koordinator
that referenced
this pull request
Feb 26, 2024
…ed (koordinator-sh#1855) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
saintube
pushed a commit
that referenced
this pull request
Feb 26, 2024
…ed (#1855) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…ed (koordinator-sh#1855) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Changes have been made in PR #1839. When
runtimeis not needed,maxwill be used as the upper limit of ElasticQuota. But it hasn't been done thoroughly yet. Since there is no need to useruntime, there is no need to calculate runtime in the PreFilter stage. In addition,GetQuotaSummaryis an externally exposed interface. It only needs to read the most recentruntime, and there is no need to recalculateruntime. If we need to computeruntimemore aggressively in the future, we should consider implementing a more efficient, cohesive method to support it.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test