-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: remove the restriction that reservation cannot be preempted #1859
scheduler: remove the restriction that reservation cannot be preempted #1859
Conversation
c36769f
to
cebe6dc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1859 +/- ##
==========================================
- Coverage 67.51% 67.50% -0.02%
==========================================
Files 416 416
Lines 46354 46333 -21
==========================================
- Hits 31297 31276 -21
- Misses 12778 12781 +3
+ Partials 2279 2276 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cebe6dc
to
7ea7554
Compare
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
7ea7554
to
ad7f84d
Compare
@buptcozy @xulinfei1996 Do you have any comments? |
/lgtm |
/lgtm |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy, FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Remove the restriction that reservation cannot be preempted. If users create reservation with priority, and mark the reservation is preemptible, the reservation can be preempted, otherwise, the reservation cannot be preempt since the priority is the highest by default.
Ⅱ. Does this pull request fix one issue?
fix #1856 implement #1887
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test