Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: remove the restriction that reservation cannot be preempted #1859

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jan 19, 2024

Ⅰ. Describe what this PR does

Remove the restriction that reservation cannot be preempted. If users create reservation with priority, and mark the reservation is preemptible, the reservation can be preempted, otherwise, the reservation cannot be preempt since the priority is the highest by default.

Ⅱ. Does this pull request fix one issue?

fix #1856 implement #1887

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.50%. Comparing base (c0374ef) to head (ad7f84d).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/scheduler/plugins/reservation/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
- Coverage   67.51%   67.50%   -0.02%     
==========================================
  Files         416      416              
  Lines       46354    46333      -21     
==========================================
- Hits        31297    31276      -21     
- Misses      12778    12781       +3     
+ Partials     2279     2276       -3     
Flag Coverage Δ
unittests 67.50% <88.88%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra eahydra marked this pull request as ready for review February 21, 2024 07:46
@eahydra eahydra force-pushed the support_preempt_reservation branch from cebe6dc to 7ea7554 Compare February 26, 2024 14:06
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the support_preempt_reservation branch from 7ea7554 to ad7f84d Compare February 26, 2024 15:20
@eahydra eahydra requested a review from xulinfei1996 February 27, 2024 02:01
@eahydra
Copy link
Member Author

eahydra commented Feb 27, 2024

@buptcozy @xulinfei1996 Do you have any comments?

@xulinfei1996
Copy link
Contributor

/lgtm

@buptcozy
Copy link
Contributor

/lgtm

@buptcozy
Copy link
Contributor

/approve

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy, FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d028567 into koordinator-sh:main Feb 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] support Reservation preemption
4 participants