proposal: support Reservation preemption #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
==========================================
+ Coverage 67.27% 67.55% +0.28%
==========================================
Files 411 413 +2
Lines 45875 46229 +354
==========================================
+ Hits 30863 31231 +368
+ Misses 12775 12730 -45
- Partials 2237 2268 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xulinfei1996
force-pushed
the
reservation-preempt
branch
2 times, most recently
from
3fefae6
to
e4ce32f
Compare
eahydra
reviewed
Feb 1, 2024
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
xulinfei1996
force-pushed
the
reservation-preempt
branch
3 times, most recently
from
c68d885
to
1da6003
Compare
eahydra
reviewed
Feb 5, 2024
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
xulinfei1996
force-pushed
the
reservation-preempt
branch
from
1da6003
to
bb5c682
Compare
eahydra
reviewed
Feb 19, 2024
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
xulinfei1996
force-pushed
the
reservation-preempt
branch
from
bb5c682
to
b49b1c9
Compare
xulinfei1996
force-pushed
the
reservation-preempt
branch
from
b49b1c9
to
a96f325
Compare
hormes
reviewed
Feb 21, 2024
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
xulinfei1996
force-pushed
the
reservation-preempt
branch
2 times, most recently
from
766aa7b
to
e8da9bc
Compare
|
/lgtm |
|
@buptcozy Do you have any further comments about the KEP? |
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
xulinfei1996
force-pushed
the
reservation-preempt
branch
from
e8da9bc
to
3531661
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Feb 26, 2024
3 tasks
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Design for #1856
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test