scheduler: extend reservation nominator to support reservation preemption #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xulinfei1996
force-pushed
the
reservation-nominate
branch
from
b0f68f6
to
bd79061
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1936 +/- ##
==========================================
+ Coverage 67.45% 67.47% +0.01%
==========================================
Files 420 420
Lines 46849 46944 +95
==========================================
+ Hits 31603 31674 +71
- Misses 12945 12966 +21
- Partials 2301 2304 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xulinfei1996
force-pushed
the
reservation-nominate
branch
from
bd79061
to
f07c4a5
Compare
eahydra
reviewed
Mar 5, 2024
pkg/scheduler/frameworkext/eventhandlers/reservation_handler.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/frameworkext/testing/fake_reservation_nominator.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/frameworkext/testing/fake_reservation_nominator.go
Outdated
Show resolved
Hide resolved
xulinfei1996
force-pushed
the
reservation-nominate
branch
3 times, most recently
from
49dcbe3
to
5970645
Compare
…tion Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
xulinfei1996
force-pushed
the
reservation-nominate
branch
from
5970645
to
f21b4d2
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…tion (koordinator-sh#1936) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Extend the reservation nominator. Reservation plugin implements the BeforeFilter function. In this function, we do add the nominated reservation infos.
Ⅱ. Does this pull request fix one issue?
fix #1935
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test