Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: optimize QueueSort func when Gang and Barepod Coexists #1977

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Mar 28, 2024

Ⅰ. Describe what this PR does

scheduler: optimize QueueSort func when Gang and Barepod Coexists

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 67.51%. Comparing base (af5f951) to head (e9ab057).
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/scheduler/plugins/coscheduling/core/core.go 0.00% 13 Missing ⚠️
pkg/scheduler/plugins/coscheduling/coscheduling.go 33.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
- Coverage   67.55%   67.51%   -0.04%     
==========================================
  Files         420      421       +1     
  Lines       47059    47100      +41     
==========================================
+ Hits        31789    31798       +9     
- Misses      12961    12987      +26     
- Partials     2309     2315       +6     
Flag Coverage Δ
unittests 67.51% <13.63%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Mar 29, 2024

This fix is LGTM.
Try to use ut to construct a problem of frequently scheduling a podgroup. After adding this fix, the problem is solved.

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2dc8735 into koordinator-sh:main Mar 29, 2024
20 checks passed
georgexiang pushed a commit to ocichina/koordinator that referenced this pull request Apr 15, 2024
…ordinator-sh#1977)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Signed-off-by: george <xiangzhihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants