-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: assure Fairness and DeadlockFree #1991
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
275f95f
to
d15a90b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
==========================================
- Coverage 68.67% 68.66% -0.02%
==========================================
Files 421 421
Lines 38779 38871 +92
==========================================
+ Hits 26632 26689 +57
- Misses 9835 9868 +33
- Partials 2312 2314 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a60bfd2
to
0e1ec3e
Compare
2. A1-A5 assumed in gangA scheduleCycle 2, C1-C5 assumed in gangA scheduleCycle 2, C7 failed due to insufficient resource and gangA\B\C cycle set to invalid, | ||
3. then B10 failed due to cycle invalid, B1 comes and find its gang scheduling cycle 2 can be valid, so it's assumed. however, we expect B1 should fail because schedule cycle 2 already failed. | ||
*/ | ||
gang.ScheduleCycle += 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里scheduleCycle的增加是什么情况,是想提前开启下一轮吗?感觉好像没什么必要; 感觉注释也有些问题,gang的scheduleCycle是在A\B\C内是独立的,为什么C7 insufficient resource会导致A6-A10的scheduleCycle校验失败
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
经过讨论,这个地方修改可以去掉
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test