Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: sort gang of same gangGroup by gangId #1997

Merged
merged 1 commit into from
Apr 11, 2024
Merged

scheduler: sort gang of same gangGroup by gangId #1997

merged 1 commit into from
Apr 11, 2024

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

buptcozy
buptcozy approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Apr 11, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ZiMengSheng ZiMengSheng mentioned this pull request Apr 11, 2024
Closed
3 tasks
scheduler: sort gang of same gangGroup by gangId
133401b 
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@koordinator-bot koordinator-bot bot removed the lgtm label Apr 11, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (10567b8) to head (133401b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1997      +/-   ##
==========================================
+ Coverage   68.67%   68.69%   +0.02%     
==========================================
  Files         421      421              
  Lines       38829    38822       -7     
==========================================
+ Hits        26667    26670       +3     
+ Misses       9854     9844      -10     
  Partials     2308     2308
Flag Coverage Δ
unittests 68.69% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng
Copy link
Contributor Author

/lgtm

@koordinator-bot
Copy link

@ZiMengSheng: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaloulcy
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Apr 11, 2024
@koordinator-bot koordinator-bot bot merged commit 252c29d into koordinator-sh:main Apr 11, 2024
20 checks passed
georgexiang pushed a commit to ocichina/koordinator that referenced this pull request Apr 15, 2024
@ZiMengSheng @georgexiang
scheduler: sort gang of same gangGroup by gangId (koordinator-sh#1997)
4c9822c 
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Signed-off-by: george <xiangzhihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buptcozy buptcozy buptcozy approved these changes

@eahydra eahydra Awaiting requested review from eahydra

Assignees

@shaloulcy shaloulcy

@buptcozy buptcozy

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZiMengSheng @shaloulcy @buptcozy