Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some nit error #2027

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

googs1025
Copy link
Contributor

Ⅰ. Describe what this PR does

  • fix some nit issue

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and FillZpp May 1, 2024 06:01
@googs1025 googs1025 changed the title fix some nit issue fix some nit error May 1, 2024
Signed-off-by: googs1025 <googs1025@gmail.com>
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (907232f) to head (591d943).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
- Coverage   68.76%   68.75%   -0.02%     
==========================================
  Files         423      423              
  Lines       39199    39199              
==========================================
- Hits        26957    26953       -4     
- Misses       9909     9910       +1     
- Partials     2333     2336       +3     
Flag Coverage Δ
unittests 68.75% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label May 6, 2024
@saintube saintube changed the title fix some nit error chore: fix some nit error May 6, 2024
@hormes
Copy link
Member

hormes commented May 7, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 114df46 into koordinator-sh:main May 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants