Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some nit error #2027

Merged
merged 1 commit into from
May 7, 2024
Merged

chore: fix some nit error #2027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/descheduler/framework/plugins/loadaware/low_node_load_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func setupFakeDiscoveryWithPolicyResource(fake *coretesting.Fake) {
})
}

func setupNodeMetrics(t *testing.T, koordClientSet koordinatorclientset.Interface, nodes []*corev1.Node, pods []*corev1.Pod, podMetrics map[types.NamespacedName]*slov1alpha1.ResourceMap) {
func setupNodeMetrics(koordClientSet koordinatorclientset.Interface, nodes []*corev1.Node, pods []*corev1.Pod, podMetrics map[types.NamespacedName]*slov1alpha1.ResourceMap) {
nodeMetrics := map[string]*slov1alpha1.NodeMetric{}
if len(pods) > 0 {
if podMetrics == nil {
Expand Down Expand Up @@ -995,7 +995,7 @@ func TestLowNodeLoad(t *testing.T) {
evictionLimiter := evictions.NewEvictionLimiter(nil, nil)

koordClientSet := koordfake.NewSimpleClientset()
setupNodeMetrics(t, koordClientSet, tt.nodes, tt.pods, tt.podMetrics)
setupNodeMetrics(koordClientSet, tt.nodes, tt.pods, tt.podMetrics)

fh, err := frameworktesting.NewFramework(
[]frameworktesting.RegisterPluginFunc{
Expand Down
2 changes: 1 addition & 1 deletion pkg/features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const (
// ElasticQuotaValidatingWebhook enables validating webhook for ElasticQuotas creations or updates
ElasticQuotaValidatingWebhook featuregate.Feature = "ElasticValidatingWebhook"

// NodeValidatingWebhook enables mutating webhook for Node Creation or updates
// NodeMutatingWebhook enables mutating webhook for Node Creation or updates
NodeMutatingWebhook featuregate.Feature = "NodeMutatingWebhook"

// NodeValidatingWebhook enables validating webhook for Node Creation or updates
Expand Down
Loading