-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-descheduler: add migration object limiter for namespace #2068
base: main
Are you sure you want to change the base?
koord-descheduler: add migration object limiter for namespace #2068
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
37e3272
to
a9a9d87
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
=======================================
Coverage 68.68% 68.68%
=======================================
Files 435 435
Lines 40703 40741 +38
=======================================
+ Hits 27955 27984 +29
- Misses 10337 10346 +9
Partials 2411 2411
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a9a9d87
to
8142750
Compare
/hold |
8142750
to
0f4dfd8
Compare
0f4dfd8
to
cd139f3
Compare
/unhold |
Signed-off-by: songtao98 <songtao2603060@gmail.com>
cd139f3
to
f8c322b
Compare
Ⅰ. Describe what this PR does
This PR add a new type of migration object limiter for namespace.
To implement this, the arbitrator of MigrationController traverses all objectLimiters and judge a pod through limiters enabled one by one.
When a pod is judged by Workload limiter, first try to get its
ownerReference
, if there is noownerReference
of this pod, just skip it.When a pod is judged by Namespace limiter, judge it by number of migrated pods in this namespace.
The similar logic is implemented in
trackEvictedPod
function, too.Ⅱ. Does this pull request fix one issue?
fixes #2051
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test