Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support builds starting with 222.* #492

Closed
wants to merge 1 commit into from
Closed

Support builds starting with 222.* #492

wants to merge 1 commit into from

Conversation

chbndrhnns
Copy link

No description provided.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #492 (45376d8) into master (fda6981) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #492   +/-   ##
=========================================
  Coverage     74.51%   74.51%           
  Complexity      307      307           
=========================================
  Files            23       23           
  Lines          1801     1801           
  Branches        518      518           
=========================================
  Hits           1342     1342           
  Misses          193      193           
  Partials        266      266           
Flag Coverage Δ
unittests 74.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda6981...45376d8. Read the comment docs.

@koxudaxi
Copy link
Owner

@chbndrhnns
Thank you for creating this PR.
I tested the PR with 222.2270.35-EAP-SNAPSHOT.
But, I got two errors.
Could you check it?
If I can get the time then I will check it.
Screenshot 2022-05-31 at 10 27 25

@chbndrhnns
Copy link
Author

I am running the same version of PyCharm locally and loaded a compiled version of the plugin there.
However, I built the plugin using IntelliJ 2022.1.1 and the 75 tests pass when I run them there.

Do we have a different setup in some aspect?

@koxudaxi
Copy link
Owner

@chbndrhnns
I used 222.2270.35-EAP-SNAPSHOT for the test

diff --git a/gradle.properties b/gradle.properties
index 353ef8f..4374971 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -9,11 +9,11 @@ pluginVersion = 0.3.12
 # See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
 # for insight into build numbers and IntelliJ Platform versions.
 pluginSinceBuild = 213.5744.223
-pluginUntilBuild = 221.*
+pluginUntilBuild = 222.*
 
 # IntelliJ Platform Properties -> https://github.com/JetBrains/gradle-intellij-plugin#intellij-platform-properties
 platformType = PC
-platformVersion = 2021.3.2
+platformVersion = 222.2270.35-EAP-SNAPSHOT

@chbndrhnns
Copy link
Author

I was missing the correct platformVersion. Now I also see two failing tests.
It's the first time I ever look at the plugin code so I am not sure I can resolve the issues by myself.

@KotlinIsland
Copy link
Contributor

This can be closed

@koxudaxi koxudaxi closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants