Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2022.2 #517

Merged
merged 14 commits into from
Jul 27, 2022
Merged

Support 2022.2 #517

merged 14 commits into from
Jul 27, 2022

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Jul 26, 2022

Related Issues

#492
#494
#516
#511

@koxudaxi
Copy link
Owner Author

@chbndrhnns @KotlinIsland
I have created the PR :)

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #517 (16df04b) into master (fda6981) will decrease coverage by 74.51%.
The diff coverage is 0.00%.

❗ Current head 16df04b differs from pull request most recent head f896c52. Consider uploading reports for the commit f896c52 to get more accurate results

@@             Coverage Diff              @@
##             master    #517       +/-   ##
============================================
- Coverage     74.51%   0.00%   -74.52%     
============================================
  Files            23      23               
  Lines          1801    1799        -2     
  Branches        518     532       +14     
============================================
- Hits           1342       0     -1342     
- Misses          193    1799     +1606     
+ Partials        266       0      -266     
Flag Coverage Δ
unittests 0.00% <0.00%> (-74.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/com/koxudaxi/pydantic/PydanticConfigPanel.kt 0.00% <0.00%> (ø)
src/com/koxudaxi/pydantic/PydanticConfigurable.kt 0.00% <ø> (ø)
.../com/koxudaxi/pydantic/PydanticIgnoreInspection.kt 0.00% <0.00%> (-100.00%) ⬇️
...om/koxudaxi/pydantic/PydanticParametersProvider.kt 0.00% <0.00%> (-100.00%) ⬇️
...koxudaxi/pydantic/PydanticDynamicModelClassType.kt 0.00% <0.00%> (-100.00%) ⬇️
src/com/koxudaxi/pydantic/PydanticAnnotator.kt 0.00% <0.00%> (-95.66%) ⬇️
...om/koxudaxi/pydantic/PydanticFieldRenameFactory.kt 0.00% <0.00%> (-93.85%) ⬇️
...koxudaxi/pydantic/PydanticTypeCheckerInspection.kt 0.00% <0.00%> (-89.00%) ⬇️
src/com/koxudaxi/pydantic/PydanticRegexInjector.kt 0.00% <0.00%> (-85.72%) ⬇️
...koxudaxi/pydantic/PydanticCompletionContributor.kt 0.00% <0.00%> (-85.19%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda6981...f896c52. Read the comment docs.


# Plugin Dependencies -> https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html
# Example: platformPlugins = com.intellij.java, com.jetbrains.php:203.4449.22
platformPlugins = python-ce

# Java language level used to compile sources and to generate the files for - Java 11 is required since 2020.3
javaVersion = 11
languageVersion = 1.7
apiVersion = 1.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are targeting 222 as a minimum, then we should be using api 1.7 and java 11, I think we should a toolchain here like in the plugin template project

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koxudaxi
Copy link
Owner Author

I updated the config. But, Jacoco doesn't cover any test cases 😢

@KotlinIsland
Copy link
Contributor

Oh sorry!, I made a mistake, 2022.2 has Java 17, not java 11. If we are targeting 222 as a minimum we should have Java 17

@koxudaxi
Copy link
Owner Author

koxudaxi commented Jul 27, 2022

I found the issue 😭
jacoco doesn't work with gradle-intellij-plugin 1.7.0.
The coverage is always 0%
JetBrains/intellij-platform-gradle-plugin#1065

@koxudaxi koxudaxi merged commit f39c87d into master Jul 27, 2022
@koxudaxi koxudaxi deleted the support_2022.2 branch July 27, 2022 18:38
@KotlinIsland
Copy link
Contributor

KotlinIsland commented Jul 27, 2022

Maybe we could use kotlinx-kover instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants