rollouts: clusterstore enhancements to support local kind clusters
#3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droot
force-pushed
the
rollouts-clusterstore-enhancements
branch
from
199f852
to
3020d33
Compare
natasha41575
approved these changes
Mar 14, 2023
| kindClusters.SetGroupVersionKind(schema.GroupVersionKind{ | ||
| Group: "", | ||
| Version: "v1", | ||
| Kind: "ConfigMapList", |
There was a problem hiding this comment.
Want to make sure I understand this correctly:
This PR introduces kind cluster support by expecting users to have ConfigMaps in the admin cluster in the kindClustersNamespace. Each ConfigMap should contain the kubeconfig for the kind cluster it represents in the data.kubeconfig.yaml field.
So next step after this PR is merged would be to write some code that can automatically create the kind clusters and associated ConfigMaps. Is that correct?
There was a problem hiding this comment.
Thanks for confirming. I’ll file an issue and get started on that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for targeting local
kindclusters.Note: I am still contemplating moving all reference of clusters by name to
ClusterRef, but little hesitant to do large refactor without much test coverage.