Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing fn-eval test #4156

Merged
merged 3 commits into from
May 28, 2024
Merged

Fix failing fn-eval test #4156

merged 3 commits into from
May 28, 2024

Commits on May 28, 2024

  1. Fix failing fn-eval test 

    The format was changed in upstream kyaml/fn version in
kubernetes-sigs/kustomize#4727.

Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
    @fsommar
    fsommar committed May 28, 2024
    Configuration menu
    Copy the full SHA
    6709c62 View commit details
    Browse the repository at this point in the history

  2. Run git diff without options in tests 

    I had issues running tests since it was using my custom settings for
`git diff`, resulting in mismatch when evaluating diffs.

I also had to prefix my commands with `env
DOCKER_DEFAULT_PLATFORM=linux/amd64` because I'm on Apple Silicon.
Otherwise, the warning output for platform mismatch also resulted in
false negatives.

Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
    @fsommar
    fsommar committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f206c3f View commit details
    Browse the repository at this point in the history

  3. Remove porch go.* files 

    Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
    @fsommar
    fsommar committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9792ad3 View commit details
    Browse the repository at this point in the history